added module to apply some ID selection at HLT #22662
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22662/4020 |
|
A new Pull Request was created by @folguera (Santiago Folgueras) for master. It involves the following packages: RecoMuon/MuonIdentification @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
|
||
| private: | ||
| edm::InputTag muonTag_; | ||
| edm::EDGetTokenT<reco::MuonCollection> muonToken_; |
There was a problem hiding this comment.
Private members of global modules should better be all const
| } | ||
| else { // Implement here manually all the required/desired cuts | ||
|
|
||
|
|
There was a problem hiding this comment.
(If you are going to update this PR) you can remove one on these empty lines
| if ( (muon.type() & requiredTypeMask_) != requiredTypeMask_ ) continue; | ||
| // tracker cuts | ||
| if ( !muon.innerTrack().isNull() ){ | ||
| if (muon.innerTrack()->hitPattern().trackerLayersWithMeasurement() < min_NTrkLayers_) continue; |
There was a problem hiding this comment.
(If you are going to update this PR) the same two spaces indentation that you use everywhere else would make this class better readable, here and below
|
comments have been integrated in these commits (sorry for the noise). |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22662/4086 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Added a module inside RecoMuon/MuonIdentification that allows to apply some ID to a collection of reco::muon objects and provides a new collection of reco::muons. It is meant to be used at HLT to apply some mild ID requirements inside the reconstruction sequence.
It needs backport to 10_0_X.