Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in the processing of RunInfo O2O magnet current #22676

Merged
merged 1 commit into from Mar 21, 2018

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Mar 20, 2018

Back-port of #22675

This fix changes the processing of the Magnet Current changes:

  • first the changes within the Run boundaries are considered
  • if no change has been found within Run boundaries, the most recent change is considered

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_10_0_X.

It involves the following packages:

CondTools/RunInfo

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Mar 20, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26975/console Started: 2018/03/20 10:34

@boudoul
Copy link
Contributor

boudoul commented Mar 20, 2018

Dear @ggovi - Just for me to understand, is this fix related to what Roberval reported recently here : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3527/1.html or it is something different ? Thank you.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22676/26975/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2468519
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468349
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.630000000048 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Mar 20, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ggovi ggovi changed the title Bug fix in the processing of magnet current changes Bug fix in the processing of RunInfo O2O magnet current Mar 20, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 47d4bd3 into cms-sw:CMSSW_10_0_X Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants