Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getParameterNames is really a const function #227

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 2, 2013

I happened to notice that both functions in the ParameterSet::getParameterSetNames overload set are really const functions, but only one of them has const in its signature. This simple pull request adds const to the signature of the other function, which should also have it. This makes one fewer non-const function of class ParameterSet.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2013

The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core

@cms-git-visualization, @cms-git-core, @cms-git-geometry

ktf added a commit that referenced this pull request Aug 2, 2013
…ction

getParameterNames is really a const function
@ktf ktf merged commit a4f487f into cms-sw:CMSSW_7_0_X Aug 2, 2013
@ktf
Copy link
Contributor

ktf commented Aug 4, 2013

@ktf
Copy link
Contributor

ktf commented Aug 4, 2013

Or even better make trackiness an enum {Tracked, Untracked, Any} and use that instead of the bool?

@wmtan
Copy link
Contributor Author

wmtan commented Aug 4, 2013

This change was resubmitted in a different pull request that removes the function ambiguity and does not cause these build errors.

jshlee referenced this pull request in gem-sw/cmssw Jun 12, 2014
…HC14

Csc trigger upgrade gem rpc for slhc14
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Feb 16, 2015
Heppy - implemented full5x5 photon clustershape methods
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
makortel pushed a commit to makortel/cmssw that referenced this pull request Apr 22, 2015
use new pkgtools tag for 74devel
arizzi added a commit to arizzi/cmssw that referenced this pull request Oct 24, 2015
cmsbuild pushed a commit that referenced this pull request Apr 5, 2016
Updated L1TStage2uGT DQM module
hyunyong pushed a commit to hyunyong/cmssw that referenced this pull request Dec 9, 2016
jbsauvan added a commit to jbsauvan/cmssw that referenced this pull request Oct 31, 2018
slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
emily-tsai11 pushed a commit to emily-tsai11/cmssw that referenced this pull request Aug 25, 2023
* fix tq input variables

* code formating
aehart pushed a commit to aehart/cmssw that referenced this pull request Sep 17, 2023
* fix tq input variables

* code formating
cmsbuild pushed a commit that referenced this pull request Dec 11, 2023
* fix tq input variables

* code formating
zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 14, 2024
* fix tq input variables

* code formating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants