Phase2-hgx106 Modify the HGCal geometry to introduce z-dependent wafer type #22727
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22727/4095 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
| @@ -116,6 +125,10 @@ void DDHGCalEEAlgo::initialize(const DDNumericArguments & nArgs, | |||
| #ifdef EDM_ML_DEBUG | |||
| edm::LogVerbatim("HGCalGeom") << "DDHGCalEEAlgo: NameSpace " << nameSpace_; | |||
| #endif | |||
|
|
|||
| waferType_ = new HGCalWaferType(rad100to200_, rad200to300_, | |||
There was a problem hiding this comment.
could this be a smart pointer?
| zMin_(zMin), | ||
| cutValue_(cutValue) { | ||
| r_ = 0.5*waferSize_; | ||
| R_ = waferSize_/std::sqrt(3.0); |
There was a problem hiding this comment.
define sqrt(3.0) as a const
|
On Mar 23, 2018, at 4:47 PM, Kevin Pedro ***@***.***> wrote:
@kpedro88 commented on this pull request.
In Geometry/HGCalCommonData/plugins/DDHGCalEEAlgo.cc:
> @@ -116,6 +125,10 @@ void DDHGCalEEAlgo::initialize(const DDNumericArguments & nArgs,
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("HGCalGeom") << "DDHGCalEEAlgo: NameSpace " << nameSpace_;
#endif
+
+ waferType_ = new HGCalWaferType(rad100to200_, rad200to300_,
could this be a smart pointer?
In Geometry/HGCalCommonData/src/HGCalWaferType.cc:
> +#include<cmath>
+
+//#define EDM_ML_DEBUG
+
+const double k_ScaleFromDDD = 0.1;
+
+HGCalWaferType::HGCalWaferType(const std::vector<double>& rad100,
+ const std::vector<double>& rad200,
+ double waferSize, double zMin,
+ int cutValue) : rad100_(rad100),
+ rad200_(rad200),
+ waferSize_(waferSize),
+ zMin_(zMin),
+ cutValue_(cutValue) {
+ r_ = 0.5*waferSize_;
+ R_ = waferSize_/std::sqrt(3.0);
define sqrt(3.0) as a const
even better - 1.0/sqrt(3.)
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22727/4097 |
|
Pull request #22727 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
|
@cmsbuild Please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
More realistic description of wafer structure