RecoTracker/TrackProducer: fix for clang warning -Woverloaded-virtual

[gartung]

In file included from /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoTracker/TrackProducer/plugins/SealModules.cc:3:
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoTracker/TrackProducer/plugins/DAFTrackProducer.h:29:8: warning: 'DAFTrackProducer::getFromEvt' hides overloaded virtual functions [-Woverloaded-virtual]
void getFromEvt(edm::Event&, edm::Handle&, reco::BeamSpot&);
^
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoTracker/TrackProducer/interface/TrackProducerBase.h:66:16: note: hidden overloaded virtual function 'TrackProducerBasereco::Track::getFromEvt' declared here: type mismatch at 2nd parameter ('edm::Handle &' (aka 'Handle<vector > &') vs 'edm::Handle &' (aka 'Handle<AssociationMap<OneToOne<vector, vectorreco::Track, unsigned short> > > &'))
virtual void getFromEvt(edm::Event&, edm::Handle&, reco::BeamSpot&);
^
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoTracker/TrackProducer/interface/TrackProducerBase.h:68:16: note: hidden overloaded virtual function 'TrackProducerBasereco::Track::getFromEvt' declared here: type mismatch at 2nd parameter ('edm::Handle &' (aka 'Handle<Viewreco::Track > &') vs 'edm::Handle &' (aka 'Handle<AssociationMap<OneToOne<vector, vectorreco::Track, unsigned short> > > &'))
virtual void getFromEvt(edm::Event&, edm::Handle&, reco::BeamSpot&);
^

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22764/4136

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

RecoTracker/TrackProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27149/console Started: 2018/03/27 22:38

[cmsbuild]

+1
Tested at: a907b1d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22764/27149/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e286936
6a6722e
d36e167
52f1966
fd1284b
b99808e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22764/27149/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22764/27149/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22764/27149/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501580
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501397
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 635.82 KiB( 16 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[perrotta]

@cmsbuild please test
(I expect that differences in tests disappear once the extra commits are not tested together)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27156/console Started: 2018/03/28 09:49

[cmsbuild]

+1
Tested at: a907b1d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22764/27156/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22764/27156/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501822
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501645
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.20000000008 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[slava77]

+1

for #22764 a907b1d

• technical disambiguation of the method name (the DAFTrackProducer::getFromEvt was not meant to override, it's just different. The DAFTrackProducer is not used in production.
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1