BugFix for L3MuonCandidateProducerFromMuons

[folguera]

Matching efficiency was degrading for very high-pt muons, this brings back the possibility of using the innerTrack when available and using the outerTrack otherwise. This recovers the missing efficiency.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22774/4144

[cmsbuild]

A new Pull Request was created by @folguera (Santiago Folgueras) for master.

It involves the following packages:

RecoMuon/L3MuonProducer

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @drkovalskyi, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27162/console Started: 2018/03/28 14:43

[silviodonato]

Even if we will definitely move to 10_1_X, I think it is good if you propagate this fix to 10_0_X too.

[cmsbuild]

+1
Tested at: 9d38e0e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22774/27162/summary.html

[cmsbuild]

Comparison job queued.

[perrotta]

This implies that for high pT muons the parameters of the muonBestTrack() are "worst" than the ones obtained from the innerTrack(), at least for this purpose. Out of curiosity: do you understand why?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22774/27162/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501822
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501645
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.17000000008 KiB( 22 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[Martin-Grunewald]

+1

[perrotta]

+1

• It recovers the high pt HLT muon inefficiency reported in https://indico.cern.ch/event/718013/contributions/2950677/attachments/1625377/2588165/2018_03_29_HLT_ND.pdf, still fulfilling the original purposes of PR Modify the track type to allow for L2 muons to pass through #22183
• Even if I got no answer here to my question in BugFix for L3MuonCandidateProducerFromMuons #22774 (comment), I think Muon POG should figure out why for high pT muons the parameters of the muonBestTrack() are "worst" than the ones obtained from the innerTrack()

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[Martin-Grunewald]

@folguera
This PR is integrated in 102X so we need another PR backporting to 101X.