SimG4CMS/Forward: Fix clang warnings -Woverloaded-virtual -Wself-assign #22789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the parameters of getEnergyDeposit to match base class by making second parameter a class member.
Remove self assign statement.
SimG4CMS/Forward/interface/ZdcSD.h:23:10: warning: 'ZdcSD::getEnergyDeposit' hides overloaded virtual function [-Woverloaded-virtual]
double getEnergyDeposit(const G4Step*, edm::ParameterSet const &);
^
/SimG4CMS/Calo/interface/CaloSD.h:60:18: note: hidden overloaded virtual function 'CaloSD::getEnergyDeposit' declared here: different number of parameters (1 vs 2)
virtual double getEnergyDeposit(G4Step* step);
^
SimG4CMS/Forward/src/CastorSD.cc:691:8: warning: explicitly assigning value of variable of type 'double' to itself [-Wself-assign]
scale=scale; // if electromagnetic, don't do anything
~~~~~^~~~~~
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22789/4160 |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: SimG4CMS/Forward @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the parameters of getEnergyDeposit to match base class by making second parameter a class member.
Remove self assign statement.
SimG4CMS/Forward/interface/ZdcSD.h:23:10: warning: 'ZdcSD::getEnergyDeposit' hides overloaded virtual function [-Woverloaded-virtual]
double getEnergyDeposit(const G4Step*, edm::ParameterSet const &);
^
/SimG4CMS/Calo/interface/CaloSD.h:60:18: note: hidden overloaded virtual function 'CaloSD::getEnergyDeposit' declared here: different number of parameters (1 vs 2)
virtual double getEnergyDeposit(G4Step* step);
^
SimG4CMS/Forward/src/CastorSD.cc:691:8: warning: explicitly assigning value of variable of type 'double' to itself [-Wself-assign]
scale=scale; // if electromagnetic, don't do anything
~~~~~^~~~~~