Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering scripts for O2Os #22798

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Mar 29, 2018

Added scripts for o2o steering in offline and online environments.
Includes the version currently deployed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ggovi
Copy link
Contributor Author

ggovi commented Mar 29, 2018

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27193/console Started: 2018/03/29 16:47

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22798/27193/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2501822
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2501645
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.11000000002 KiB( 23 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Apr 3, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2018

@ggovi just a question, would not be better to have this tree under the scripts subdirectory?

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2018

@ggovi this could be considered afterwards, please let me know what you think anyway

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2018

+1

@cmsbuild cmsbuild merged commit a62378e into cms-sw:master Apr 4, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2018

@ggovi late comment (as in 10_1_X review): in your scripts 10_0_5 is mentioned, is this intended? These are standalone new scripts so I do not see how they could break existing workflows, but I would like to be sure that they are what is really needed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants