Phase2-hgx107 Add a new shape for hexgonal geometry

[bsunanda]

This is the hexagonal geometry as would be used for HGCal silicon cells/wafers

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22810/4189

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloGeometry

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27211/console Started: 2018/03/30 23:56

[cmsbuild]

+1
Tested at: 7f6ce4e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22810/27211/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22810/27211/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501849
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501672
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.11000000004 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@bsunanda , as I understand this is work in progress, later this shape will be included in unit tests.

[bsunanda]

@civanch Yes it is work in progress. I have to get the access of information of geometry information to make reconstruction geometry. I can add a unit test later on

[fabiocos]

@bsunanda a unit test would be useful indeed, the code as it is is harmless, but was it tested already?

[bsunanda]

@fabiocos I shall add a useful unit test later on. I am right now working on reecho geometry and for this it is needed

[bsunanda]

@fabiocos I did some private test before committing this to repository

[fabiocos]

+1