[Tag-N-Probe] Split read mode #22861
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22861/4251 |
|
A new Pull Request was created by @drkovalskyi for master. It involves the following packages: PhysicsTools/TagAndProbe @gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
At a quick read it looks ok to me, but me and @arizzi are supposed to put the +1 only on NanoAOD-related PRs, and this one is not. |
|
I have checked muon efficiency measures for Run2017 and got identical results, but I cannot test all use cases since I'm not familiar with them and I don't see any unit tests to check it. So far we started using it in Muon POG for new measurements, so it's pretty much production already. |
|
@drkovalskyi I understand this is not running in standard production wf, is it correct? Or which are them in case? |
|
It's not running in the standard production, but it's widely used by different groups. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
Added a new mode of running TagNProbe code that uses less memory by creating RooDataSet for each bin individually and reading data from the input TTree in chunks. It allows to reduce memory usage for typical fits done by Muon POG from ~20GB down to 1-2GB. The code runs significantly slower in the new mode, so it shouldn't be a default option. The change should not affect any code unless the new mode is requested explicitly and even in this case all results should be the same.