Phase2-hgx106 Step toward HGCal interface of Geometry #22891
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22891/4275 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@kpedro88 Can you please approve this? |
| @@ -130,3 +132,17 @@ bool HGCalParametersFromDD::build(const DDCompactView* cpv, | |||
| << ok; | |||
| return ok; | |||
| } | |||
|
|
|||
| double HGCalParametersFromDD::getDDDVallue(const char* s, | |||
There was a problem hiding this comment.
fix spelling Vallue -> Value
|
@cmsbuild Please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22891/4303 |
|
The tests are being triggered in jenkins. |
|
Pull request #22891 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@ianna Please review and approve this |
| @@ -13,6 +14,9 @@ class HGCalParametersFromDD { | |||
|
|
|||
| bool build(const DDCompactView*, HGCalParameters&, const std::string&, | |||
| const std::string&, const std::string&); | |||
|
|
|||
| private: | |||
| double getDDDValue(const char* s, const DDsvalues_type& sv); | |||
There was a problem hiding this comment.
@bsunanda - I do not see you using this here. Please remove it.
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Defines all parameters needed to for deciding numbering cells