Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deep flavour of MiniAOD v2 to NANOAOD #22898

Merged

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Apr 8, 2018

last minute forgotten MiniAODv2 feature to be imported in nanoaod

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

A new Pull Request was created by @arizzi for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/NanoAOD

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arizzi
Copy link
Contributor Author

arizzi commented Apr 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27380/console Started: 2018/04/08 09:07

@arizzi
Copy link
Contributor Author

arizzi commented Apr 8, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@arizzi
Copy link
Contributor Author

arizzi commented Apr 8, 2018

master PR will come tomorrow

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22898/27380/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 109
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721222
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 110 log files, 9 edm output root files, 27 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 8, 2018

please test workflow 1325.6,1325.8,1325.9

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27381/console Started: 2018/04/09 00:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22898/27381/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22898/1325.6_TTbar_13_94Xv1NanoAODINPUT+TTbar_13_94Xv1NanoAODINPUT+NANOAODMC2017_94XMiniAODv1
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22898/1325.8_TTbar_13_94Xv1NanoAODINPUT+TTbar_13_94Xv1NanoAODINPUT+NANOEDMMC2017_94XMiniAODv1+HARVESTNANOAODMC2017_94XMiniAODv1
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22898/1325.9_TTbar_13_92XNanoAODINPUT+TTbar_13_92XNanoAODINPUT+NANOEDMMC2017_92X+HARVESTNANOAODMC2017_92X

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 107
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721224
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 110 log files, 9 edm output root files, 27 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2018

+1

@cmsbuild cmsbuild merged commit 12d5af2 into cms-sw:CMSSW_9_4_X Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants