Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT DQM online fix (101X backport) #22902

Merged
merged 2 commits into from Apr 12, 2018
Merged

Conversation

silviodonato
Copy link
Contributor

101X backport of #22901

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_10_1_X.

It involves the following packages:

DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@silviodonato
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Apr 8, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27383/console Started: 2018/04/09 00:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22902/27383/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2504051
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2503874
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.10000000001 KiB( 23 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Pull request #22902 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

@silviodonato
Copy link
Contributor Author

unhold

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27393/console Started: 2018/04/09 11:02

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22902/27393/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2504051
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2503874
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.0100000001 KiB( 21 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@silviodonato
Copy link
Contributor Author

@vazzolini, @kmaeshima, @dmitrijus, @jfernan2, @vanbesien I think this is an important fix to run HLT DQM online in the next data taking. You might also consider to ask for a patch release in order to use this fix as soon as possible at P5.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0baa5c7 into cms-sw:CMSSW_10_1_X Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants