Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctpps pixel dqm: protect against RP ID corruption - backport 22889 #22906

Merged
merged 2 commits into from Apr 15, 2018

Conversation

popovvp
Copy link
Contributor

@popovvp popovvp commented Apr 8, 2018

protect against station + RP IDs corruption

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

A new Pull Request was created by @popovvp for CMSSW_10_1_X.

It involves the following packages:

DQM/CTPPS

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Pull request #22906 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

@popovvp popovvp changed the title protect against RP ID corruption - backport 22889 ctpps pixel dqm: protect against RP ID corruption - backport 22889 Apr 9, 2018
@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27389/console Started: 2018/04/09 09:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22906/27389/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2504051
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2503874
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.900000000176 KiB( 23 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

+1
backport of #22889

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 59e7fdc into cms-sw:CMSSW_10_1_X Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants