Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 HE pedestal analysis #2292

Merged
merged 2 commits into from Feb 5, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Feb 4, 2014

  • Remove use of HcalTopology builder in HcalPedestalAnalysis

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

Phase2 HE pedestal analysis

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalStandardModules
Configuration/Geometry

@civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @rcastello, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Feb 4, 2014

+1

@mark-grimes
Copy link

merge

3300, 4100, 4400, 40001, 50002, 60002, 4502, 4500 and 5001 pass

3400 and 15001 fail in harvesting - known error introduced by #2265 (test uses incorrect customisation for step 4).
50001 and 60001 fail in step1 - known error introduced by #2236 (FastSim only).

3400 with combinedCustoms.cust_2019WithGem seg faults in harvesting with the same stack trace as for #2250. Known issue (test uses incorrect customisation for step 4).

cmsbuild added a commit that referenced this pull request Feb 5, 2014
@cmsbuild cmsbuild merged commit be9fa94 into cms-sw:CMSSW_6_2_X_SLHC Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants