New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix noise in dqmMemoryStats #22925
Fix noise in dqmMemoryStats #22925
Conversation
This should prevenv the noise in PR comparisons where nothing changed, except for the release name.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22925/4312 |
A new Pull Request was created by @schneiml (Marcel Schneider) for master. It involves the following packages: DQMServices/FileIO @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
-1 Tested at: 2c41e36 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
I suspect the test failure is not my fault. |
I suspect you are right. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@schneiml thanks, I do not think that the small fluctuations were a big issue, as they are clearly distinguishable from large changes, but still it can be useful to concentrale on the real change in the histogram themselves. |
+1 |
Assume constant size for strings in dqmMemoryStats.
This should prevent the noise in PR comparisons (
DQMHistoSizes
) where nothing changed, except for the release name.Note that this will not be effective when testing this PR, cms-bot appears to use the base IB version of the script.
A PR to cms-bot improving the ouptut in general will come soon.