Remove unused simTrackHits parameter from some L1 track trigger code

[makortel]

This PR suggests to remove simTrackHits parameter from two places in L1 track trigger code where I found them confusing and not used. (confusion arose from the need to understand whether these modules actually need g4SimHits or not in the context of pileup mixing)

Tested in CMSSW_10_1_0, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22929/4315

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

L1Trigger/TrackTrigger
SimTracker/TrackTriggerAssociation

@cmsbuild, @civanch, @kpedro88, @nsmith-, @rekovic, @mdhildreth, @thomreis can you please review it and eventually sign? Thanks.
@kreczko, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @sviret, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27434/console Started: 2018/04/11 14:31

[boudoul]

Thanks @makortel - I'm not sure why is was there is the first place -
Let me just attract the attention of @mdhildreth (actually mostly because I do not know the github name of Rachael who is charge of this package, maybe Mike can propagate this PR to her) - Thanks

[sviret]

@boudoul this is historical, initially the simhits were also matched. At some point the simhits were removed from the event content, but apparently everything was not fully cleaned up.

[makortel]

Thanks @sviret for the confirmation that these can indeed be safely clean up.

[cmsbuild]

+1
Tested at: d7411b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22929/27434/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22929/27434/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2505375
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2505198
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.899999999936 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[kpedro88]

+1

[civanch]

+1

[fabiocos]

@thomreis @nsmith- @rekovic could you please check and sing in case?

[fabiocos]

@thomreis @nsmith- @rekovic could you please check and sing in case?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1