DD4Hep Algorithms and Shapes

[ianna]

• Includes DD4Hep: Migrate Run 1 Tracker Algorithms #22643
• Add more CMS-specific shapes

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22936/4322

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27439/console Started: 2018/04/11 18:01

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

I'm surprised that some of these file have AIDA copyright. Are such files unique to CMS or are they copied from DD4Hep? If so, should we make those an external?

[civanch]

@ianna , may be having detailed discussion on design of DD4Hep is needed? We may suffer from tails of old thread unsafe frameworks.

[cmsbuild]

-1

Tested at: 1ed0770

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22936/27439/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step3

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[ianna]

@Dr15Jones - these files are unique to CMS and should be under our control for at least some time allow smooth integration with CMS framework. Markus and I are working on the code together. As you may have noticed, there is a lot of copying back and forth. The CMS Tracker Pixel from run 1 is an example in DD4Hep repository.
I agree, the long term ownership and the code distribution should be discussed, so should be the copyright.

[ianna]

@civanch - I'm confident, we can help with threadsafety of DD4Hep when it is an issue.

[cmsbuild]

Pull request #22936 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22936/4420

[cmsbuild]

Pull request #22936 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27579/console Started: 2018/04/20 13:39

[cmsbuild]

-1

Tested at: 64be013

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22936/27579/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-19-2300/src/DetectorDescription/DDCMS/plugins/DDCMSDetector.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-19-2300/src/DetectorDescription/DDCMS/plugins/DDTECModuleAlgo.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-19-2300/src/DetectorDescription/DDCMS/plugins/DDTIBLayerAlgo.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-19-2300/src/DetectorDescription/DDCMS/plugins/DDTrackerAngular.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-19-2300/src/DetectorDescription/DDCMS/test/DDUnits.cppunit.cc:3:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-19-2300/src/DetectorDescription/DDCMS/interface/DDUnits.h:8:23: error: constexpr variable '_pi' must be initialized by a constant expression
constexpr long double _pi = std::acos(-1);
                      ^     ~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/nweek-02520/slc6_amd64_gcc630/external/gcc/6.3.0/lib/gcc/x86_64-unknown-linux-gnu/6.3.0/../../../../include/c++/6.3.0/cmath:123:14: note: subexpression not valid in a constant expression
    { return __builtin_acos(__x); }
             ^


[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22936/27579/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2492830
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2492653
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[ianna]

Replaced by #23037