Move premixing worker plugins to packages with corresponding MixingModule plugins #22953
Conversation
Using it makes the worker interface closer to MixingModule DigiMixAccumulatorMixMod interface, and allows to use edm::Handle to retrieve data products from pileup events.
|
The code-checks are being triggered in jenkins. |
makortel
changed the title
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22953/4338 |
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: SimCalorimetry/EcalSimProducers The following packages do not have a category, yet: SimGeneral/PreMixingModule @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test workflow 250202.0,250202.17,250202.18,250402.0 |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 3321534 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error1001.0 step1 DAS Error |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@cmsbuild, please test workflow 250202.0,250202.17,250202.18,250402.0 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 good move |
This PR makes two technical updates to the PreMixingModule introduced in #22416 (both to make the plugin code closer to MixingModule plugins)
PileUpEventPrincipalfromMixingModuleedm::Handle+getByLabel()to retrieve data products instead ofstd::shared_ptr+getProductByTag()plugins, and in my opinion it is better to place the premixing plugins there as well rather than moving the phase2 tracker digitizer code tointerface+src.Tested in CMSSW_10_2_X_2018-04-12-2300, no changes expected.
@kpedro88 @mdhildreth