Combined updates for SiStrip Payload Inspector

[mmusich]

Several updates to the SiStrip Payload Inspector:

• add the zero pedestals fraction plot to SiStrip pedestals;
• add the Payload inspector class for the SiStripConfObject CondFormat;
• add auxiliary class to store averaged conditions per APV and Module;
• add value and comparison plots averaged per Strip, APV and Module for Pedestals and Noise;
• update README and unit tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22969/4353

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ggovi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27511/console Started: 2018/04/16 16:13

[cmsbuild]

-1

Tested at: bc3f9ed

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22969/27511/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

[cmsbuild]

Comparison job queued.

[mmusich]

sorry for being insistent, but is there any hope of getting this tested?

[fabiocos]

@mmusich the crash is an annoying long-standing "feature" of fastsim that has nothing to do with this PR as far as I can see. For my understanding: in which test workflow if any is this code supposed to run, apart for the standalone test code in the PR itself?

[mmusich]

For my understanding: in which test workflow if any is this code supposed to run, apart for the standalone test code in the PR itself?

@fabiocos: indeed no other workflow is involved

[fabiocos]

@ggovi could you please check and sign in case? The addOn failure has nothing to do with this PR

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27601/console Started: 2018/04/22 20:36

[cmsbuild]

+1
Tested at: afbb294
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22969/27601/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22969/27601/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2492830
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2492653
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1