HCALDQM: Update DigiTask for 2018 HE (10_1_X backport)

[DryRun]

Backport of #22724 to 10_1_X (the original PR was intended for 10_1_X, but was merged in 10_2_X).

Updates HCALDQM DigiTask for 2018 HE. A number of plots were not filled for HEP17 last year because it would have mixed QIE8 and QIE11 digis; QIE11-specific plots were created in QIE11Task. Now that HE==QIE11, I integrated the plots of interest from QIE11Task to DigiTask.

I also included one small bug fix for LaserTask: with the 2018 HE, the range for the laser signal has to be increased.

#22971 should be merged first.

[cmsbuild]

A new Pull Request was created by @DryRun (David Yu) for CMSSW_10_1_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks
DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @deguio, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27510/console Started: 2018/04/16 16:08

[cmsbuild]

+1
Tested at: e07aec5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22972/27510/summary.html

[cmsbuild]

Comparison job queued.

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27754/console Started: 2018/05/02 15:58

[fabiocos]

This PR looks needed to fix a problem reported in prompt RECO, see the thread

https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/1870.html

@DryRun thanks for the fast reaction, this PR was not highlighted as crucial for data taking, and since its master version entered into CMSSW_10_2_0_pre2 that is still under validation, I was waiting for the outcome of that check to integrate it into CMSSW_10_1_X. At this point this is becoming more a fix, but I would like to understand what is causing the crash and why this did not appear so far

[fabiocos]

@dmitrijus @jfernan2 @schneiml BTW I understand this is running in online DQM already?

[DryRun]

Hi @fabio, I was also surprised that it didn't crash earlier. The reason is that the histogram that causes the crash is filled very rarely, only when a QIE10/QIE11 returns a TDC value that is not allowed in the specification.

Regarding online DQM, this PR is indeed deployed, as part of #23006.

[cmsbuild]

+1
Tested at: e07aec5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22972/27754/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22972/27754/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2506331
• DQMHistoTests: Total failures: 277
• DQMHistoTests: Total nulls: 47
• DQMHistoTests: Total successes: 2505831
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 17982.718 KiB( 28 files compared)
• DQMHistoSizes: changed ( 1306.0,... ): 938.532 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 1306.0,... ): 0.007 KiB RecoTauV/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.007 KiB HLT/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB L1T/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB Tracking/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB L1TEMU/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB DT/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB Pixel/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB RPC/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB Muons/EventInfo
• DQMHistoSizes: changed ( 1306.0 ): ...
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1