Update the ADC->fC table, simplify the charge reconstruction algorithm

[deguio]

backport of #22974

@jkunkle @mariadalfonso

[cmsbuild]

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_10_1_X.

It involves the following packages:

RecoMET/METFilters
RecoMET/METProducers

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Update the ADC->fC table, simplify the charge reconstruction algorith… #22974

[perrotta]

@deguio @jkunkle @mariadalfonso

Is this backport to 10_1_X still needed/requested? (Also considering that the PR in the master still has to be merged and validated in RelVals before any backport can be taken into account, and the expected date for the release of 10_2_0 is not that far away)

If so, please update and put it in synchro with the version in the master.

If not, then you can probably close this pull request

[cmsbuild]

Pull request #22976 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

[deguio]

hi @perrotta
I think it still makes sense to include this PR in 10_1_x so that we can start using it before 10_2 is deployed.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28284/console Started: 2018/05/30 12:20

[cmsbuild]

+1
Tested at: ea810fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22976/28284/summary.html

[cmsbuild]

Comparison job queued.

[deguio]

hi @perrotta
the laserMon system is something that exists only at p5 and the corresponding channels do not exist in MC. so I would expect the totalLaserMon charge to be -1 accordingly to:
https://github.com/deguio/cmssw/blob/ea810fb98d32301e7c5426d68cb312bce36408c0/RecoMET/METProducers/src/HcalNoiseInfoProducer.cc#L761

does this answer your question?

[cmsbuild]

Pull request #22976 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

[deguio]

two commits pushed to add PR #23597 as well to the 10_1_x queue

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28862/console Started: 2018/06/25 12:30

[cmsbuild]

+1
Tested at: 7d16a15
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22976/28862/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22976/28862/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2523351
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2523174
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[perrotta]

+1

• Since previous reco signature in [muon] updated mva weights and tuned the default values #23637: [muon] updated mva weights and tuned the default values (SK), the last update jusr add the content of PR Disable hcalLaserEventFilter occupancy filter  #23597 to this backport
• Therefore this PR implements the overall backport of Disable hcalLaserEventFilter occupancy filter  #23597 and Update the ADC->fC table, simplify the charge reconstruction algorith… #22974 from the master to 10_1_X

[fabiocos]

+1

[fabiocos]

merge