New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Parameter existence check since done by fillDescriptions #22985
Remove Parameter existence check since done by fillDescriptions #22985
Conversation
Removed the check on the existence of a given Parameter since the presence of a fillDescription method automatically guarantees that the Parameter will exist. This also fixes a gcc7 compiler warning.
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22985/4372 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: PhysicsTools/NanoAOD @gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
Removed the check on the existence of a given Parameter since the
presence of a fillDescription method automatically guarantees that
the Parameter will exist.
This also fixes a gcc7 compiler warning.