Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error reported by Valgrind #2299

Merged
merged 1 commit into from Feb 5, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Feb 4, 2014

Fix this error:
==6514== Mismatched free() / delete / delete []
reported by valgrind. This is a minimal fix for the
reported problem.

Note there are some other strange looking things in the file
that I did not fix. The following line appears to mistakenly
use ">" instead of "<"
if (matchedCand.pt() > ptBins.at(0)) { // underflow problem

This fix is for 7_0_X and 7_1_X. There are similar
problems in 6_2_X which someone might want to fix if this
is used in 6_2_X, although the code has been modified since
then so the exact same fix will not work.

Fix this error:
 ==6514== Mismatched free() / delete / delete []
reported by valgrind. This is a minimal fix for the
reported problem.

Note there are some other strange looking things in the file
that I did not fix.  The following line appears to mistakenly
use ">" instead of "<"
    if (matchedCand.pt() > ptBins.at(0)) { // underflow problem

This fix is for 7_0_X and 7_1_X. There are similar
problems in 6_2_X which someone might want to fix if this
is used in 6_2_X, although the code has been modified since
then so the exact same fix will not work.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_0_X.

Fix error reported by Valgrind

It involves the following packages:

DQMOffline/PFTau

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

@ktf
Copy link
Contributor

ktf commented Feb 5, 2014

Bypassing DQM and ORP signature, since this is obviously a bug fix.

@davidlange6

ktf added a commit that referenced this pull request Feb 5, 2014
DQM fixes -- Fix error reported by Valgrind in DQMOffline/PFTau
@ktf ktf merged commit 5626ce2 into cms-sw:CMSSW_7_0_X Feb 5, 2014
@wddgit wddgit deleted the fix70XMatchCandidateBenchmark branch May 8, 2014 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants