fixes for AddOn Test Failures #23019
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23019/4417 |
|
A new Pull Request was created by @skurz for master. It involves the following packages: FastSimulation/SimplifiedGeometryPropagator @cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
| // in very few events the Decayer (pythia) produces high mass resonances that are for some reason not present in the table (even though they should technically be) | ||
| // they have short lifetimes, so decay them right away (charge and lifetime cannot be taken from table) | ||
| particle->setRemainingProperLifeTimeC(0.); | ||
| particle->setCharge(0.); |
There was a problem hiding this comment.
So far we've observed particles with pdgIDs 9010221 and 30443. They can be produced if a non-stable particle is decayed https://github.com/skurz/cmssw/blob/157e9a58bcfcc99d62a9744e34edec23d5f0b2ab/FastSimulation/SimplifiedGeometryPropagator/src/Decayer.cc#L33
There was a problem hiding this comment.
For an initial test of 6000 events, there was no crash with the fix (whereas the current version crashes).
| @@ -147,7 +147,8 @@ double fastsim::HelixTrajectory::nextCrossingTimeC(const BarrelSimplifiedGeometr | |||
| if(std::abs(layer.getRadius() - getRadParticle(phi1)) > 1.0e-2 | |||
| || std::abs(layer.getRadius() - getRadParticle(phi2)) > 1.0e-2) | |||
| { | |||
| return ((StraightTrajectory*) this)->nextCrossingTimeC(layer, onLayer); | |||
| StraightTrajectory traj(*((Trajectory*) this)); | |||
There was a problem hiding this comment.
The cast is unnecessary.
|
Comparison job queued. |
|
I ran a few tests as well:
|
|
Comparison is ready Comparison Summary:
|
|
@skurz @ssekmen could you please look at @Dr15Jones comment and then confirm if this PR is ok for you? It would be good to have it into 10_2_0_pre2 at the beginning of next week |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23019/4434 |
|
@fabiocos I removed the cast according to the comment, so the PR should be ready for sign off. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fastsim-approved
fully-signed
and removed
fastsim-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Adressed two issues discussed in #22721 that could lead to rare failures in case of large production samples.
-> Cast in HelixTrajectory did not work, so now explicitly included CopyConstructor
-> HepPDT::ParticleData does not contain information about some high mass resonances that are sometimes produced by the pythia decayer even though they should be according to [2]. They have short lifetimes so decay them again right away.
[2] http://pdg.lbl.gov/2007/reviews/montecarlorpp.pdf