New fastsim geometry fix, AddOn faliure fix - backport to 94X

[ssekmen]

Backports of
#22202: New FastSim geometry fix
#23019: fixes for AddOn Test Failures

[ssekmen]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31012/console Started: 2018/10/13 04:56

[cmsbuild]

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_9_4_X.

It involves the following packages:

FastSimulation/SimplifiedGeometryPropagator

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: e07d187
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24861/31012/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24861/31012/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 103
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721228
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[ssekmen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@ssekmen was this verified to fix the problems observed in 9_4_11_cand1?

[fabiocos]

+1

[ssekmen]

@fabiocos , I did a test with 4000 events and all was ok (crash was happening around ~2500th event).