Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: DQM update #23025

Merged
merged 22 commits into from
May 3, 2018
Merged

CTPPS: DQM update #23025

merged 22 commits into from
May 3, 2018

Conversation

jan-kaspar
Copy link
Contributor

This PR collects several improvements of CTPPS DQM plots, including those fundamental for the upcoming 90m run.

Changes in general CTPPS plots

  • removed unused trigger-related plots
  • added correlation plots between pots of different technologies (strips, pixels, diamonds etc.)
  • optimisation of diamond plots
  • strips: kept only plots for pots used in 2018

Plots for 90m run

  • strips: U/V trigger-sector correlation plots

Plots for low-energy run

Note: some of the new plots are only relevant for special runs (CTPPS alignment, low-energy, etc.). These plots are built by a dedicated module ElasticPlotDQMSource which is by default not included in the processing sequence. It is agreed with the DQM team that the module can be included for the special runs upon our demand.

The updated code was tested on the data from the 2018 CTPPS run with this config: DQM/CTPPS/test/all_ctpps_dqm_test_from_aod_cfg.py.

runTheMatrix.py -l limited gave 23 22 21 17 9 1 1 1 1 tests passed, 1 1 0 0 0 0 0 0 0 failed. The two failing tests

  • 4.22: Step0-DAS_ERROR
  • 136.7611: Step1-FAILED

don't seem related to this PR.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jan-kaspar
Copy link
Contributor Author

Could someone restart the test? I don't believe that there is any reason for it to fail. With the same code the test passed on 23 April.

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27770/console Started: 2018/05/03 15:19

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23025/27770/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2712006
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2711822
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -22508.2 KiB( 29 files compared)
  • DQMHistoSizes: changed ( 136.731,... ): -1059.404 KiB CTPPS/TrackingStrip
  • DQMHistoSizes: changed ( 136.731,... ): -984.516 KiB CTPPS/TimingDiamond
  • DQMHistoSizes: changed ( 136.731,... ): 18.739 KiB CTPPS/common
  • DQMHistoSizes: changed ( 136.731,... ): -15.659 KiB CTPPS/events per BX
  • DQMHistoSizes: changed ( 136.731,... ): -4.225 KiB CTPPS/Trigger
  • DQMHistoSizes: changed ( 136.731,... ): -0.433 KiB CTPPS/events per BX (short)
  • DQMHistoSizes: changed ( 136.731,... ): -0.423 KiB CTPPS/DAQ
  • DQMHistoSizes: changed ( 136.731,... ): -0.280 KiB CTPPS/track correlation all hor
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2018

+1

@cmsbuild cmsbuild merged commit 0a60f48 into cms-sw:master May 3, 2018
@fabiocos fabiocos mentioned this pull request May 3, 2018
@forthommel forthommel deleted the ctpps_dqm_update_10_2_0_pre1 branch May 4, 2018 07:56
cmsbuild added a commit that referenced this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants