Totem timing DQM

[forthommel]

This PR introduces the DQM for Totem vertical timing detectors, using TotemTimingDigi.
It was discussed on last Friday's reco & analysis tools meeting.

To be included in DQM at P5 during the alignment run (occuring this Saturday morning) to commission the detectors.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22915/4302

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

CondFormats/CTPPSReadoutObjects
DQM/CTPPS
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
EventFilter/CTPPSRawToDigi
RecoCTPPS/Configuration

@perrotta, @civanch, @vazzolini, @kmaeshima, @arunhep, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @jfernan2, @cerminar, @slava77, @ggovi, @vanbesien, @lpernie can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @rovere, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27414/console Started: 2018/04/10 14:16

[cmsbuild]

-1

Tested at: 24bb748

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22915/27414/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 2 hours.

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[forthommel]

It looks like we reached a timeout with 20434.0...

[dmitrijus]

please test

[cmsbuild]

Pull request #22915 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[perrotta]

please test with #23101

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27896/console Started: 2018/05/10 13:30

[cmsbuild]

+1
Tested at: 0695010
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22915/27896/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c3e5e3d
e23e914
f2654ff
4ff6c07
a2efcfb
b5d5881
aa11fed
445ccd0
2eea6e5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22915/27896/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22915/27896/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22915/27896/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2713999
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2713815
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 34668.183 KiB( 29 files compared)
• DQMHistoSizes: changed ( 10824.0,... ): 3151.653 KiB CTPPS/TimingFastSilicon
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[nminafra]

@fabiocos could you remove the hold, if it is fine with you?

[dmitrijus]

+1
(still needs to be unheld)

[fabiocos]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@nminafra thank you for the revision, I think it is ok to go

[fabiocos]

+1