New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-hcx174 HcalDetId is meant for HB/HE/HO/HF only #23029
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23029/4431 |
A new Pull Request was created by @bsunanda for master. It involves the following packages: DataFormats/DetId @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
@fabiocos Sorry Fabio for touching DetId.h again |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@civanch Please approve this PR |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos Could you please merge this? |
+1 |
Avoids the warnings in HcalUnpack