L1T DQM Remove etsum collection empty check.

[thomreis]

Remove the check if the two etsums are empty from the calo L2 to uGT comparison. This leads to mismatches otherwise when the calo L2 is not in the run.

This reintroduces the changes done in #22878 that were removed with #22961 and in addition protects against the iterator trying to read from the end of the collection.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23041/4440

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27613/console Started: 2018/04/23 17:29

[cmsbuild]

+1
Tested at: aa06383
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23041/27613/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23041/27613/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2492830
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2492653
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1