Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to the short matrix the extra workflows run in cms-bot PR tests #23073

Merged
merged 1 commit into from May 2, 2018

Conversation

fabiocos
Copy link
Contributor

When running the short test matrix on PRs, cms-bot adds to the basic runTheMatrix.py definition some additional tests, defined in https://github.com/cms-sw/cms-bot/blob/master/cmssw-pr-test-config .
This PR moves these extra additions into the regular CMSSW implementation, and adds the new test for premix, as proposed in cms-sw/cms-bot#978

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27671/console Started: 2018/04/26 19:24

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23073/27671/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23073/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2495054
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2494877
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented May 2, 2018

@fabozzi @prebello @kpedro88 @slava77 @perrotta @makortel @smuzaffar so any objection to this PR? cms-sw/cms-bot#978 has been merged, so it is not so crucial, but still it brings into the release this feature

@prebello
Copy link
Contributor

prebello commented May 2, 2018

+1

tests approved, including new pmx-stg1+stg2 relval, so @fabiocos no objection to me
Do you agree @fabozzi ?

@fabozzi
Copy link
Contributor

fabozzi commented May 2, 2018

@prebello @fabiocos
no objections from me too

@perrotta
Copy link
Contributor

perrotta commented May 2, 2018

It makes sense to me.
But I let @slava77 decide for reco, since he started some discussion about it in cms-sw/cms-bot#978

@slava77
Copy link
Contributor

slava77 commented May 2, 2018

I didn't start a discussion there, I was just responding to a question.
This PR does not need a reco signature.

@kpedro88
Copy link
Contributor

kpedro88 commented May 2, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

fabiocos commented May 2, 2018

+1

@cmsbuild cmsbuild merged commit f4c25ff into cms-sw:master May 2, 2018
@fabiocos fabiocos deleted the fc-update-matrix branch May 9, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants