New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SiStrip Miscalibration Tools [10.2.X] #23084
Conversation
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23084/4493 |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondTools/SiStrip @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23084/4494 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Greetings,
this PR is meant to update/ add tools used for the creation of Strip conditions for simulation, starting from existing payloads in database.
SiStripChannelGainFromDBMiscalibrator
: reads APV gains (either G1 or G2) from DB and applies hierarchically a scale factor and/or gaussian smearing for each APV gain, down to the individual layer or disk level.SiStripNoisesFromDBMiscalibrator
: reads Noise from DB and applies hierarchically a scale factor and/or gaussian smearing for each APV gain, down to the individual layer or disk level.Code has been refactored to avoid duplication, moving common methods to an helper file; in addition the configuration and existing documentation have been updated.