Changes to ECAL TTF4 DQM plots (for CMSSW master) #23087
Conversation
…w turns RED when the fraction of towers in a given SM that have TTF4 flag set is greater than a threshold fraction which is currently set to 0.05.
…l number of towers in EB and EE with TTF4 flag set.
…evel; the ttFlag container now has meaningful values above 4 for situations where not all strip in a tower are masked. This requires the following changes to the DQM code: (1) TTF4 occupancy now counts all towers with ttF >= 4, not just ttF == 4 (2) Flag mismatch for low interest, medium interest regions: only perform check if ttF == 1 or ttF == 3 (3) For data/emulator comparisons, ignore towers with ttF > 4
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23087/4496 |
|
A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for master. It involves the following packages: DQM/EcalMonitorClient @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
tanmaymudholkar
changed the title
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test I assume that most of the observed differences are unrelated to this package |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
This PR is also meant to be deployed in production at P5. Corresponding PR to 10_1_X: PR#23088
Changes introduced:
(1) Added alarm to trigger primitives quality summary plot -- the plot now turns RED when the fraction of towers in a given SM that have TTF4 flag set is greater than a threshold fraction which is currently set to 0.1.
(2) Added trend plots for the total number of towers in EB and EE with TTF4 flag set.
(3) COKE in the endcaps can mask on the strip level, not just the tower level; the ttFlag container now has meaningful values above 4 for situations where not all strip in a tower are masked. This requires the following changes to the DQM code:
(3.1) TTF4 occupancy now counts all towers with ttF >= 4, not just ttF == 4
(3.2) Flag mismatch for low interest, medium interest regions: only perform check if ttF == 1 or ttF == 3
(3.3) For data/emulator comparisons, ignore towers with ttF > 4