Make legacy and uROS DT packer naming consistent for InputTag cfg parameter [10_1_X]

[battibass]

Backport of PR # 23091

[cmsbuild]

A new Pull Request was created by @battibass (Carlo Battilana) for CMSSW_10_1_X.

It involves the following packages:

EventFilter/DTRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Make legacy and uROS DT packer naming consistent for InputTag cfg parameter [10_2_X] #23091

[slava77]

Backport of #23091

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27755/console Started: 2018/05/02 16:42

[cmsbuild]

+1
Tested at: 94c179d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23092/27755/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23092/27755/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2506331
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2506154
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.167 KiB( 28 files compared)
• DQMHistoSizes: changed ( 1306.0,... ): 0.007 KiB RecoTauV/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB L1T/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB SiStrip/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB L1TEMU/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB DT/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB Pixel/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB RPC/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB Muons/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB HLT/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB Ecal/EventInfo
• DQMHistoSizes: changed ( 1306.0 ): ...
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[slava77]

DQMHistoSizes: changed ( 1306.0,... ): 0.007 KiB RecoTauV/EventInfo

@dmitrijus
It looks like effectively zero diffs are polluting the comparisons.
is it possible to put a threshold to these details?
Do I interpret correctly that only the first few are shown? If they are sorted by abs value, there is no harm, just some nuisance. However, if there is no sorting, then the lack of threshold is a problem.

[slava77]

+1

for #23092 94c179d

• this fixes the premixing problems in DT in the same way as in the master version (Make legacy and uROS DT packer naming consistent for InputTag cfg parameter [10_2_X] #23091 e6246b2)
• jenkins tests pass and comparisons show no differences. The 2018 premixing workflow running in jenkins in 102X is not a part of 10_1_X, which explains lack of differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1