-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make legacy and uROS DT packer naming consistent for InputTag cfg parameter [10_2_X] #23091
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23091/4505 |
A new Pull Request was created by @battibass (Carlo Battilana) for master. It involves the following packages: EventFilter/DTRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@cmsbuild, please test Let's try again now that we (should) have a premixing workflow in the PR tests. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@cmsbuild please test to get reco comparisons as well after cms-sw/cms-bot#981 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@slava77 the new run still show differences just in the wf 250202.181 |
+1 |
This PR makes the legacy and uROS packer input tag cfg parameter names consistent.
It is expected to have impact on premixing workflows as it makes this line work in the expected way.
It should be addressing (at the bare minimum a fraction of) the issues observed in 102X/101X for muons for premixing.