Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T DQM Retire unneeded caloLayer2 data-emulator ratio plots - 101x #23097

Merged

Conversation

thomreis
Copy link
Contributor

backport of #23096

The caloLayer2 data over emulator ratio plots are not needed anymore since there re now dedicated event by event comparison plots for the data vs. emulator agreement checks.

The running of the caloLayer2 DQM module in the emulator client also results in a race condition in the DQMGUI where the histograms produced by the l1tstage2 client race against the ones from the l1tstage2emulator client. Since the later have much less events as they only run in fat events, only the ones from the l1tstage2 client are desired. With the removal of the ratio plots the l1tstage2emulator version of the histograms are not needed anymore and could be removed.

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27715/console Started: 2018/04/30 11:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2018

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_10_1_X.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23097/27715/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2506331
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2506154
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.808 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 140.53,... ): 0.006 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.005 KiB L1T/L1TriggerVsReco
  • DQMHistoSizes: changed ( 140.53,... ): 0.005 KiB DT/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.004 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.003 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.002 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.002 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 140.53 ): 0.002 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.001 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 150.0 ): -0.012 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 150.0 ): ...
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3df120d into cms-sw:CMSSW_10_1_X May 11, 2018
@fabiocos fabiocos mentioned this pull request May 11, 2018
6 tasks
@thomreis thomreis deleted the l1t_dqm_fix_calol2_race_condition-101x branch August 20, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants