New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T DQM Retire unneeded caloLayer2 data-emulator ratio plots - 101x #23097
L1T DQM Retire unneeded caloLayer2 data-emulator ratio plots - 101x #23097
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_10_1_X. It involves the following packages: DQM/L1TMonitor @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #23096
The caloLayer2 data over emulator ratio plots are not needed anymore since there re now dedicated event by event comparison plots for the data vs. emulator agreement checks.
The running of the caloLayer2 DQM module in the emulator client also results in a race condition in the DQMGUI where the histograms produced by the l1tstage2 client race against the ones from the l1tstage2emulator client. Since the later have much less events as they only run in fat events, only the ones from the l1tstage2 client are desired. With the removal of the ratio plots the l1tstage2emulator version of the histograms are not needed anymore and could be removed.