New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix premix setting in MatrixInjector #23104
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23104/4523 |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: Configuration/PyReleaseValidation @GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
Good catch, thanks for the fix! |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
type bugfix |
+1 |
@zhenhu observed a failure when submitting relvals for 10_2_0_pre2. #22583 added the
premix_stage2
modifier to the RECO step in premixed workflows. However, the--pileup_input
argument is not provided for the RECO step, so this led to an issue in theMatrixInjector
.This PR has a simple proposed fix (tested by @zhenhu).
attn: @makortel