Implement jet ID for PUPPI jets

[ahinzmann]

This implements jet ID for PUPPI jets and applies it in Offline DQM.

In CMSSW>=10_1_X this should have a small effect on the CleanedslimmedJetsPuppi DQM plots, since the jet ID is based on puppiMultiplicties available in MiniAOD.

(In CMSSW_9_4_X this would remove a large fraction of forward jets in the CleanedslimmedJetsPuppi DQM plots if #23012 is not applied. If #23012 is applied on top, this should have a small effect.)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23120/4536

[cmsbuild]

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

DQMOffline/JetMET
PhysicsTools/SelectorUtils

@perrotta, @monttj, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @slava77, @gpetruc, @vanbesien, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @rappoccio, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27763/console Started: 2018/05/03 00:02

[cmsbuild]

-1

Tested at: 0c0f2e7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23120/27763/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 2 hours.

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[perrotta]

@cmsbuild please test
(relvals timed out: let try again)

[cmsbuild]

Pull request #23120 was updated. @perrotta, @monttj, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @slava77, @gpetruc, @vanbesien, @arizzi can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27842/console Started: 2018/05/08 07:12

[cmsbuild]

+1
Tested at: b6c9039
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23120/27842/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23120/27842/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2713614
• DQMHistoTests: Total failures: 2979
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2710452
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[ahinzmann]

This behaves as expected now:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_2_X_2018-05-07-2300+23120/26431/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/JetMET__Jet_CleanedslimmedJetsPuppi_Constituents_Forward.png
Ready to go from my point of view.

[dmitrijus]

+1

[slava77]

+1

for #23120 b6c9039

• technical changes since the last reco signoff in reco-related code PhysicsTools/SelectorUtils (Implement jet ID for PUPPI jets #23120 0c0f2e7); main changes in the last update were in the DQM code
• jenkins tests pass and comparisons with the baseline show differences only in the DQM monitoring, including folders Jet/CleanedslimmedJetsPuppi|Jet/CleanedslimmedJetsAK8|MET/slimmedMETsPuppi. The changes are apparently expected and primarily affect the forward regions, e.g. wf 136.8311

[slava77]

@fabiocos
please check this at your earliest. I'd like this to be in the release before signing off on #23012

[slava77]

@fabiocos
please clarify if there are some issues with this PR.
Thank you.

[fabiocos]

+1

[fabiocos]

merge