Update TriggerIdLoose definition to recover the efficiency in low-pT (backport to 10_1_X)

[KyeongPil-Lee]

Backport of #23124

This PR updates the muon station requirement in TriggerIdLoose to recover the efficiency of low-pT (a few GeV) muons.
Backport is needed.

[cmsbuild]

A new Pull Request was created by @KyeongPil-Lee for CMSSW_10_1_X.

It involves the following packages:

DataFormats/MuonReco

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @folguera, @abbiendi, @rovere, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @amagitte, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Update TriggerIdLoose definition to recover the efficiency in low-pT #23124

[slava77]

based on the tests already completed in the master branch, this PR changes the content of RECO and miniAOD objects.

This is not allowed in the production release. An exception will need to be discussed.
There is a RECO meeting tomorrow and an ORP next Tuesday.
@drkovalskyi @folguera

[drkovalskyi]

We are using offline selection online now. Are you suggesting that we have to move all that code under HLT to avoid this policy? We are changing meaning of one bit.

[slava77]

On 5/4/18 12:30 AM, drkovalskyi wrote: We are using offline selection online now. Are you suggesting that we have to move all that code under HLT to avoid this policy? We are changing meaning of one bit.

If this flag is only useful for online an easy way to decouple is to add a config parameter and enable it in HLT. If it's still needed in the offline files, then perhaps some versioning is needed, otherwise you are not going to be able to change the implementation of the selector during the year. we are still early enough in 10_1_X that an exception is possible both for data and for MC.

[drkovalskyi]

It's expected that it will get stable as most muon selectors are and will be used for long time. At the moment we are still in integration phase because only now TSG is putting it all into the menu. A typical use case offline would be to check the id to get an estimated performance of the trigger id where it makes sense to do it. Getting it all right is too much work and we don't have manpower to support it or any need to do it.

[slava77]

from the discussion in the RECO meeting, I expect that it should be possible to include this PR within the policy constraints due to other significant changes that have to go to the release.
Future tweaks may not be as lucky.

[drkovalskyi]

We will need to have more detailed instructions how to handle offline for online for future changes.

[slava77]

We will need to have more detailed instructions how to handle offline for online for future changes.

the only clear solution is a configurable one; the selector for online may have to be versioned or reimplemented in the HLT producer if/when it's different.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27814/console Started: 2018/05/04 21:29

[cmsbuild]

+1
Tested at: e1196cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23125/27814/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23125/27814/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2507116
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2506939
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.611 KiB( 28 files compared)
• DQMHistoSizes: changed ( 25202.0 ): 0.006 KiB SiStrip/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB Tracking/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB L1TEMU/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB HLT/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB DT/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB RPC/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.004 KiB Muons/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.004 KiB Pixel/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.002 KiB RecoTauV/EventInfo
• DQMHistoSizes: changed ( 25202.0,... ): 0.002 KiB Ecal/EventInfo
• DQMHistoSizes: changed ( 140.53 ): ...
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[slava77]

+1

for #23125 e1196cf

• changes are the same as in the master branch PR Update TriggerIdLoose definition to recover the efficiency in low-pT #23124 6b8258b
• jenkins tests pass and comparisons with the baseline show differences only in reco::Muon::selectors variables both in miniAOD and in RECO outputs and correspond to changes in the TriggerIdLoose flag values.

This PR affects outputs both for the standard MC and data.
As discussed in this and the master PR, the value of the flag is still of rather limited use. Considering that the main 10_1_X MC campaign didn't start yet and that data processing is pending some other updates, this PR can be included in 10_1_X without introducing any additional dataset incompatibility.
@fabiocos I think that there is no need to wait for the master/10_2_X relval reports to integrate this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1