updating GENSIM strings

[prebello]

This PR aims to update GENSIM strings to be applied in next pre-releases.

FYI @fabiocos @fabozzi

[cmsbuild]

The code-checks are being triggered in jenkins.

[prebello]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23135/4548

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27781/console Started: 2018/05/03 22:08

[cmsbuild]

A new Pull Request was created by @prebello (Patricia Rebello Teles) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 5ec6fd4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23135/27781/summary.html

[cmsbuild]

Comparison job queued.

[fabozzi]

+1

[kpedro88]

+1

[makortel]

@fabozzi Is the culprit again 250202.181? My best idea would be to get access to the output of makeDiff.sh to see what it is doing (in addition to the earlier stack trace). @smuzaffar, is there any way to do that?

[fabozzi]

@makortel
yes, it was stuck again at 250202.181:
https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/26452/console

[makortel]

@smuzaffar @fabozzi
Let me ask another clarification: how do we know it is 250202.181 that is stuck? From the log it is the last workflow for which the alternative-comparisons is launched (because it is the last workflow in the list?), but it is not clear to me which line(s) in the log say that this workflow is the stuck one (ok, last time
@smuzaffar checked it explicitly #23135 (comment)).

This PR likely changes ~everything for 250202.181 (as the pileup GEN-SIM is changed). But the scripts should have some minimum thresholds for the level of changes to limit the time and output for such cases, right? Or could it be that there are too many larger-than-highest-threshold changes?

[smuzaffar]

@makortel , as you noticed in my comment ( #23135 (comment) ) , workflow 250202.181 was the last workflow to run and was the only workflow running at that time for more than 3 hours.

Currently there is 6 hours timeout for full comparison job but I agree that we should add some timeout per comparison job too. Is 30mins/comparison is good enough estimate?

[makortel]

@smuzaffar Per-comparison-job timeout is fine for me, but I'd still like to understand why 250202.181 is causing problems now (while presumably other pileup workflows have not caused similar problems earlier when their pileup MinBias GEN-SIM has been updated).

[makortel]

I started to run makeDiff.sh locally with the DQM root files of baseline and baseline+PR. My expectation is that it will run long and make gazillion plots.

[slava77]

@cmsbuild please test

looks like the old tests/console are not available anymore

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27962/console Started: 2018/05/15 18:32

[cmsbuild]

+1
Tested at: 5ec6fd4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23135/27962/summary.html

[cmsbuild]

Comparison job queued.

[makortel]

makeDiff.sh without any limits took 5.5 hours and produced a PDF of 256 MB. But it is not clear to me from the console output
https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/26507/console
if any thresholds are applied in practice.

[slava77]

On 5/16/18 9:34 AM, Matti Kortelainen wrote: |makeDiff.sh| without any limits took 5.5 hours and produced a PDF of 256 MB. But it is not clear to me from the console output https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/26507/console if any thresholds are applied in practice.

what's "grep -c ^Save " in the log file ?

[makortel]

I didn't save the log, but the PDF has 81388 pages.

[slava77]

it appears that the threshold assignment logic failed for 250202.181
cms-sw/cms-bot#986 should fix it

[makortel]

Thanks @slava77 !

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23135/27962/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2356 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2715235
• DQMHistoTests: Total failures: 9964
• DQMHistoTests: Total nulls: 10
• DQMHistoTests: Total successes: 2705078
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.964 KiB( 29 files compared)
• DQMHistoSizes: changed ( 250202.181 ): 1.964 KiB SiStrip/MechanicalView
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[fabiocos]

+1

all the differences are concentrated in the wf 250202.181 , pre2 corresponds to the integration of the new premixing code

@slava77 thank you for catching the problem in cms-bot