HCALDQM: Monitor bad capid rotation, uHTR/L1T mismatches (10_1_X)

[DryRun]

Backport of #23140.

Adds the following, mostly related to the issues seen so far in 2018:

• Monitor bad capid rotation. (BX - capid) % 4 should be a constant.
• Monitor uHTR-L1T mismatches. This is copied straight from the L1T DQM code, but it's extremely useful for HCAL.

Minor additions:

• Add LED pin diode plots to local DQM.
• UMNioTask now handles LED events correctly, instead of labeling them HF.
• Implement code rule check as suggested by Fabio. These were all "using namespace * in header" violations, which were fairly ubiquitous in the HcalCommon infrastructure.

[cmsbuild]

Pull request #23141 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[cmsbuild]

Pull request #23141 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[cmsbuild]

Pull request #23141 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[dmitrijus]

Once again, this PR has some extra commits which are not merged in master... :(

[DryRun]

Hi @dmitrijus - are you referring to the last two commits? These were merged in master this morning in #23221. Sorry if this was confusing, I can try to make a new backport PR next time.

[dmitrijus]

Yes, I was. You really need to mention them once you add them :)

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28044/console Started: 2018/05/18 15:19

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: dcae4b6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23141/28044/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23141/28044/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2508870
• DQMHistoTests: Total failures: 169
• DQMHistoTests: Total nulls: 507
• DQMHistoTests: Total successes: 2508018
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 5519.213 KiB( 28 files compared)
• DQMHistoSizes: changed ( 25202.0,... ): 224.647 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 25202.0,... ): 0.188 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 2.625 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 4.22 ): 17.438 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 10024.0,... ): 373.909 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 10024.0,... ): 0.199 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 1000.0 ): 4.000 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 136.731 ): 1.527 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 136.788 ): 8.035 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 4.53 ): 20.688 KiB Hcal/DigiRunHarvesting
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[jfernan2]

Successfully tested and integrated in the Online DQM at P5. https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMP5TagCollector
Merged in master

[fabiocos]

+1

merged in CMSSW_10_2_0_pre4, no problem reported in validation