Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test of tensorflow AOT #23146

Merged
merged 1 commit into from May 10, 2018
Merged

test of tensorflow AOT #23146

merged 1 commit into from May 10, 2018

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented May 4, 2018

testing the new SCRAM feature to generate AOT code given a model and config.

Not obvious to me where the .pb and config files should eventually be located
(they need to be shared at least by src/plugin and test directory in a package.)

In general there is no need to expose further the generated AOT as it is expected to be encapsulated in an algorithm or module

file and example copied from tensorflow/compile/aot/tests itself

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

PhysicsTools/TensorFlow

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@VinInn
Copy link
Contributor Author

VinInn commented May 4, 2018

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27802/console Started: 2018/05/04 16:02

@VinInn
Copy link
Contributor Author

VinInn commented May 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23146/27802/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2713580
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713396
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 7, 2018

+1

for #23146 15b5e01

  • changes are only in PhysicsTools/TensorFlow/test and appear to be in line with the PR description
  • jenkins tests pass (compilation logs look OK)

@fabiocos
Copy link
Contributor

@smuzaffar @VinInn in the preliminary discussion about TF DNN in AOT format it was stated that the basic data files should go into a cms-data package, as usual. In the present PR though we are having just small input files for test. They can be an exception in this respect.

@smuzaffar
Copy link
Contributor

@fabiocos , yes this small binary file within cmssw is to make sure that scram rule for DNN is working correctly.

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants