Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-alca129 Uptodate the macros for IsoTrack calibration for 2018 #23159

Merged
merged 2 commits into from May 9, 2018

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 7, 2018

Introduce new PU corrections for 2018 data analysis

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

bsunanda commented May 7, 2018

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27834/console Started: 2018/05/07 18:09

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23159/27834/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2713614
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713430
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

bsunanda commented May 7, 2018

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27840/console Started: 2018/05/08 05:30

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

Pull request #23159 was updated. @cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23159/27840/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2713614
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713430
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@arunhep
Copy link
Contributor

arunhep commented May 8, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2018

+1

@cmsbuild cmsbuild merged commit 6ff2ee3 into cms-sw:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants