-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapting E/gamma miniAOD for the 80X re-miniAOD V2: 9_4_X MiniAOD #23169
Adapting E/gamma miniAOD for the 80X re-miniAOD V2: 9_4_X MiniAOD #23169
Conversation
A new Pull Request was created by @Sam-Harper for CMSSW_9_4_MAOD_X. It involves the following packages: RecoEgamma/EgammaPhotonProducers @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #22975 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 8e62f63 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
@cmsbuild please test with cms-sw/cmsdist#3972 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos |
@slava77 no, this is ok to move as we have the auxiliary branch, I have merged also the corresponding external |
+1 |
Dear All,
This is the 94X backport of #22975
Best,
Sam