Adapting E/gamma miniAOD for the 80X re-miniAOD V2: 9_4_X MiniAOD

[Sam-Harper]

Dear All,

This is the 94X backport of #22975

Best,
Sam

[cmsbuild]

A new Pull Request was created by @Sam-Harper for CMSSW_9_4_MAOD_X.

It involves the following packages:

RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @varuns23, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Adapting E/gamma miniAOD for the 80X re-miniAOD V2: 10_2_X #22975

[perrotta]

backport of #22975

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27861/console Started: 2018/05/08 15:41

[cmsbuild]

-1

Tested at: 8e62f63

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23169/27861/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[perrotta]

@cmsbuild please test with cms-sw/cmsdist#3972

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3972
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27867/console

[cmsbuild]

+1
Tested at: 8e62f63
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23169/27867/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23169/27867/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 56 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 108
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721223
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[slava77]

+1

for #23169 8e62f63

• backport from the master version Adapting E/gamma miniAOD for the 80X re-miniAOD V2: 10_2_X #22975 51fe9f8 is correct
• jenkins tests pass and comparisons with the baseline show differences only in the re-miniAOD of 80X inputs in wf 136.7611. Changes are apparently the same as in the master version based on spot-check of a few distributions.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

@fabiocos
please clarify if some action is needed from reco/developers side for this PR.

[fabiocos]

@slava77 no, this is ok to move as we have the auxiliary branch, I have merged also the corresponding external

[fabiocos]

+1