Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLTTauDQM: fixed empty hpstau trg object histograms #23175

Merged
merged 1 commit into from May 18, 2018

Conversation

slehti
Copy link
Contributor

@slehti slehti commented May 9, 2018

HLT Tau pt,eta,phi histograms empty with HPS PFTau paths. Fixed.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

A new Pull Request was created by @slehti for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented May 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27878/console Started: 2018/05/09 13:43

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23175/27878/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2713999
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713815
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@slehti the DQM comparison is not showing any difference, from the purpose of this PR I would expect to see some difference, could you please explain?

@slehti
Copy link
Contributor Author

slehti commented May 16, 2018

Directory PFTaus, paths
HLT_DoubleMediumChargedIsoPFTauHPS35.. HLT_IsoMu20_eta2p1_LooseChargedIsoPFTauHPS27... HLT_IsoMu20_eta2p1_MediumChargedIsoPFTauHPS35...
histograms TrigTauEt, TrigTauEta, TrigTauPhi

These were not filled before this fix.

@fabiocos
Copy link
Contributor

@slehti I assume you verified yourself that the plots are filled, because in the test run in this PR it does not look to be the case, according to the above report and also rerunning the plots of 10824 on my own

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4ce5809 into cms-sw:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants