New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix headers in EventFilter pkgs #23176
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23176/4610 |
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: EventFilter/GEMRawToDigi @perrotta, @cmsbuild, @emeschi, @nsmith-, @rekovic, @thomreis, @slava77, @mommsen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -1,6 +1,8 @@ | |||
#ifndef EventFilter_L1TRawToDigi_PackerTokens_h | |||
#define EventFilter_L1TRawToDigi_PackerTokens_h | |||
|
|||
#include "FWCore/Utilities/interface/EDGetToken.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not look right.
@@ -1,5 +1,6 @@ | |||
#ifndef EventFilter_GEMRawToDigi_VFATdata_h | |||
#define EventFilter_GEMRawToDigi_VFATdata_h | |||
#include "stdint.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system includes are typically in the brackets <stdint.h>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed here #23189. I'd separate this pr into pieces
Add missing headers for passing check-headers scram check