Adding 2018A data relvals #23196
Adding 2018A data relvals #23196
Conversation
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23196/4649 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @fabozzi for master. It involves the following packages: Configuration/PyReleaseValidation @GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Tested at: 1b0b14e You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
after more careful checks on the global tags, it seems like we are consistently loading correct L1T menu everywhere and also the HLT key is correct. |
|
Dear all, the issue is not there, since I got the same crash even without L1TDQM sequence for EGamma. We spotted a suspicious message in the DIGI step related to "L1REPACK:Full" sequence. Therefore I have contacted L1T experts to have a look at that (no reply yet). |
|
@fabozzi the reproducible crash happens in the HCAL DQM: ++++++++ starting: processing event for module: stream = 0 label = 'digiPhase1Task' id = 887 A fatal system signal has occurred: segmentation violation Thread 3 (Thread 0x7f6113acf700 (LWP 6940)): The L1T message should be understood, it comes from the master sequences @thomreis could you please clarify whether the message should be updated, or the code should be fixed? It is anyway useful to check also the other workflows, to see whether there are other issues |
|
please test with #23221 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
@fabiocos OK, thanks! |
|
+1 |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pdmv-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 this PR adds by default one 2018 test wf to the short matrix, we need to discuss whether some further review of the short matrix is useful |
This PR is a follow up to the discussion in issue #23130.
We choose run 315489 for 2018A data relvals.
The relval on EGamma PD replaces relvals on DoubleEG, SinglePhoton and SingleElectron for previous eras.
A 2018A workflow is also included in the short matrix.