Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stuff from 612slh6 that is ahead of 70x and 620 #232

Merged
merged 2 commits into from Aug 28, 2013
Merged

stuff from 612slh6 that is ahead of 70x and 620 #232

merged 2 commits into from Aug 28, 2013

Conversation

davidlange6
Copy link
Contributor

Partial resync of changes from 612SLH6 that are apparently not yet ported to 70x (or 620)

Geometry/CMSCommonData
Geometry/Records
RecoVertex/PrimaryVertexProducer
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
SimCalorimetry/HcalZeroSuppressionProducers
SimDataFormats/CaloHit
DataFormats/HcalDigi
DataFormats/HcalRecHit
CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
DataFormats/HcalCalibObjects

@ktf
Copy link
Contributor

ktf commented Aug 5, 2013

@slava77 @thspeer @mdhildreth @civanch Can you please review and sign?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2013

The following categories have been signed by @civanch: Full Simulation

@cms-git-simulation

@ktf
Copy link
Contributor

ktf commented Aug 5, 2013

@demattia can you please look into this?

@thspeer
Copy link
Contributor

thspeer commented Aug 6, 2013

I see many small differences when running the usual matrix (-s) in tracking, PV, PF, jets, etc. Is this expected?

thspeer
thspeer reviewed Aug 6, 2013
View reviewed changes
RecoVertex/PrimaryVertexProducer/interface/PrimaryVertexProducer.h
@@ -80,6 +83,4 @@ class PrimaryVertexProducer : public edm::EDProducer {

edm::ParameterSet theConfig;
bool fVerbose;
edm::EDGetTokenT<reco::BeamSpot> bsToken;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an older version than in the IB. I had changed PV to use the consumes API and the tokens. Please update PrimaryVertexProducer.h and .cc

@davidlange6
Copy link
Contributor Author

Given the changes to

OfflinePixel3DPrimaryVertices_cfi

yes. I'm a bit surprised to see that we were ahead of 62x/70x in this
regard.

On 8/6/2013 1:20 AM, thspeer wrote:

I see many small differences when running the usual matrix (-s) in
tracking, PV, PF, jets, etc. Is this expected?

—
Reply to this email directly or view it on GitHub
#232 (comment).

@davidlange6
Copy link
Contributor Author

Regarding PrimaryVertexProducer.cc and .h - sorry for that - I've updated my request to fix that

@demattia
Copy link
Contributor

demattia commented Aug 7, 2013

Hi, adding HCAL experts in cc.

It seems several HCAL calibrations taken from software tags have been changed. In this sense, it is not surprising that there are changes in jetMEt related quantities.
I let them comment further on the expected effects of the changes.

Marco

Marco De Mattia
Purdue University
e-mail: marco.de.mattia@cern.chmailto:marco.de.mattia@cern.ch
website:http://demattia.web.cern.ch/demattia/

On Aug 6, 2013, at 10:20 AM, thspeer <notifications@github.commailto:notifications@github.com> wrote:

I see many small differences when running the usual matrix (-s) in tracking, PV, PF, jets, etc. Is this expected?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/232#issuecomment-22164198.

@nclopezo
Copy link
Contributor

nclopezo commented Aug 7, 2013

Hi,

I took CMSSW_7_0_X_2013-08-07-0200, pulled these changes, and ran the RelVals and unit tests, all tests passed.

And build logs can be found here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/70/consoleFull

@davidlange6
Copy link
Contributor Author

@demattia , which change(s) specifically do you believe changes conditions when running with a GT (eg, as normal) rather than with hard coded conditions ?

@demattia
Copy link
Contributor

demattia commented Aug 8, 2013

Looking at this:
https://github.com/cms-sw/cmssw/pull/232/files
I see several changes for HFRecalibration.

As I am not entirely sure of their effect I wanted to bring into the discussion the HCAL AlCa contacts.

Marco

Marco De Mattia
Purdue University
e-mail: marco.de.mattia@cern.chmailto:marco.de.mattia@cern.ch
website:http://demattia.web.cern.ch/demattia/

On Aug 8, 2013, at 12:52 AM, davidlange6 <notifications@github.commailto:notifications@github.com> wrote:

@demattiahttps://github.com/demattia , which change(s) specifically do you believe changes conditions when running with a GT (eg, as normal) rather than with hard coded conditions ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/232#issuecomment-22290473.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2013

The following categories have been signed by yana (a.k.a. @ianna on GitHub): Geometry

@cms-git-visualization, @cms-git-geometry

@davidlange6
Copy link
Contributor Author

@demattia : who has been contacted from the hcal?

in any case HE/HFRecalibration are off by default unless someone turned on H*Darkening in 70x (which I see are set to false)

@demattia
Copy link
Contributor

demattia commented Aug 9, 2013

The AlCa contacts for HCAL: Jordan Damgov and Dmitry Vishnevskiy.
I contacted them on this thread and with a private mail, but I did not receive any feedback yet.

Marco

Marco De Mattia
Purdue University
e-mail: marco.de.mattia@cern.chmailto:marco.de.mattia@cern.ch
website:http://demattia.web.cern.ch/demattia/

On Aug 8, 2013, at 7:19 PM, davidlange6 <notifications@github.commailto:notifications@github.com> wrote:

@demattiahttps://github.com/demattia : who has been contacted from the hcal?

in any case HE/HFRecalibration are off by default unless someone turned on H*Darkening in 70x (which I see are set to false)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/232#issuecomment-22339409.

@ktf
Copy link
Contributor

ktf commented Aug 16, 2013

@demattia any updates about this?

@ghost ghost assigned demattia Aug 16, 2013
@cmsbuild
Copy link
Contributor

The following categories have been signed by @civanch: Full Simulation

@cms-git-simulation

@davidlange6
Copy link
Contributor Author

Ping?? Maybe its time to push this in unless there is a specific objection?

@cmsbuild
Copy link
Contributor

The following categories have been signed by yana (a.k.a. @ianna on GitHub): Geometry

@cms-git-visualization, @cms-git-geometry

@demattia
Copy link
Contributor

+1
I did not receive any update after several mails. I see that @davidlange6 made tests and that everything works fine, so I will approve it.

ktf added a commit that referenced this pull request Aug 28, 2013
@ktf
Merge pull request #232 from davidlange6/forward_port_612slhc6
a491c02 
stuff from 612slh6 that is ahead of 70x and 620
@ktf ktf merged commit a491c02 into cms-sw:CMSSW_7_0_X Aug 28, 2013
jshlee referenced this pull request in gem-sw/cmssw Jun 12, 2014
@jshlee
Merge pull request #232 from jshlee/CSCTF-Me11aunganged
2b0172b 
remove temp file
makortel pushed a commit to makortel/cmssw that referenced this pull request Apr 22, 2015
@ktf
Merge pull request cms-sw#232 from ktf/master
9bb0063 
Do not assume scripts are in $WORKSPACE.
cvernier pushed a commit to cvernier/cmssw that referenced this pull request Oct 24, 2015
@arizzi
Merge pull request cms-sw#232 from arizzi/V15fixes2
58d84a1 
Samples and PU weights
hyunyong pushed a commit to hyunyong/cmssw that referenced this pull request Dec 10, 2016
@jshlee
Merge pull request cms-sw#232 from jshlee/GEMCosmicMuon
bebbbd0 
Gem cosmic muon
bi-ran pushed a commit to bi-ran/cmssw that referenced this pull request Jul 12, 2019
@mandrenguyen @bi-ran
Bug fix for new heavy jet flavor definition (cms-sw#232)
43c57fa
aehart pushed a commit to aehart/cmssw that referenced this pull request Sep 17, 2023
@Chriisbrown @tomalin
Track quality file name update (cms-sw#232)
32b827f 
* Rename clf_GBDT_emulation_newKF_digitized.json to L1_TrackQuality_GBDT_emulation_digitized.json

* Update TrackQualityParams_cfi.py

* Add comment describing the default BDT
cmsbuild pushed a commit that referenced this pull request Dec 11, 2023
@Chriisbrown @tomalin
Track quality file name update (#232)
58c7dc5 
* Rename clf_GBDT_emulation_newKF_digitized.json to L1_TrackQuality_GBDT_emulation_digitized.json

* Update TrackQualityParams_cfi.py

* Add comment describing the default BDT
zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 14, 2024
@Chriisbrown
Track quality file name update (cms-sw#232)
ab89f62 
* Rename clf_GBDT_emulation_newKF_digitized.json to L1_TrackQuality_GBDT_emulation_digitized.json

* Update TrackQualityParams_cfi.py

* Add comment describing the default BDT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@demattia demattia

Labels
alca-approved geometry-approved pending-signatures reconstruction-pending simulation-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@davidlange6 @ktf @cmsbuild @thspeer @demattia @nclopezo