Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply most of python futurist stage1 tools for python3 compatibility #23208

Merged
merged 3 commits into from May 23, 2018

Conversation

davidlange6
Copy link
Contributor

-f lib2to3.fixes.fix_apply
-f lib2to3.fixes.fix_except
-f lib2to3.fixes.fix_exitfunc
-f lib2to3.fixes.fix_funcattrs
-f lib2to3.fixes.fix_has_key
-f lib2to3.fixes.fix_idioms
-f lib2to3.fixes.fix_intern
-f lib2to3.fixes.fix_isinstance
-f lib2to3.fixes.fix_methodattrs
-f lib2to3.fixes.fix_ne
-f lib2to3.fixes.fix_numliterals
-f lib2to3.fixes.fix_paren
-f lib2to3.fixes.fix_reduce
-f lib2to3.fixes.fix_renames
-f lib2to3.fixes.fix_repr
-f lib2to3.fixes.fix_standarderror
-f lib2to3.fixes.fix_sys_exc
-f lib2to3.fixes.fix_throw
-f lib2to3.fixes.fix_tuple_params
-f lib2to3.fixes.fix_types
-f lib2to3.fixes.fix_xreadlines
-f libfuturize.fixes.fix_absolute_import
-f libfuturize.fixes.fix_next_call
-f libfuturize.fixes.fix_raise

["most" in terms of tools, but the remaining ones affect more code]

Other than the changes to argparse.py in RecoLuminosity changes are minor - the argparse file looks to be obsolete in any case. I'll look at removing it in favor of the standard one...

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/CommonAlignment
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignment
Alignment/MuonAlignmentAlgorithms
CalibMuon/DTCalibration
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CalibTracker/SiStripDCS
CondCore/PopCon
CondCore/Utilities
CondTools/Ecal
CondTools/SiStrip
Configuration/Applications
Configuration/DataProcessing
Configuration/PyReleaseValidation
Configuration/StandardSequences
DQM/CSCMonitorModule
DQM/Integration
DQMServices/Components
DQMServices/Diagnostic
DQMServices/FileIO
DataFormats/FWLite
Documentation/ReferenceManualScripts
EventFilter/HcalRawToDigi
EventFilter/L1TXRawToDigi
EventFilter/RPCRawToDigi
FWCore/GuiBrowsers
FWCore/ParameterSet
FWCore/Utilities
FastSimulation/Validation
HLTrigger/Configuration
HLTrigger/HLTanalyzers
HLTrigger/Tools
L1Trigger/L1TCalorimeter
L1Trigger/L1TGlobal
PhysicsTools/Heppy
PhysicsTools/HeppyCore
PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
PhysicsTools/PythonAnalysis
PhysicsTools/SelectorUtils
RecoEgamma/ElectronIdentification
RecoLuminosity/LumiDB
RecoMET/METFilters
RecoTauTag/TauTagTools
RecoVertex/BeamSpotProducer
SimTracker/TrackerMaterialAnalysis
Utilities/RelMon
Utilities/ReleaseScripts
Validation/Performance
Validation/RecoMuon
Validation/RecoTau
Validation/RecoTrack
Validation/RecoVertex

@lveldere, @cmsdoxy, @kpedro88, @fabozzi, @nsmith-, @rekovic, @thomreis, @vanbesien, @arizzi, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @ssekmen, @mdhildreth, @jfernan2, @cerminar, @slava77, @ggovi, @fabiocos, @Martin-Grunewald, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @gpetruc, @lpernie can you please review it and eventually sign? Thanks.
@echabert, @TaiSakuma, @gouskos, @felicepantaleo, @jainshilpi, @schoef, @rappoccio, @argiro, @Martin-Grunewald, @imarches, @thomreis, @tlampen, @ahinzmann, @lgray, @abbiendi, @mmusich, @seemasharmafnal, @venturia, @pakhotin, @mmarionncern, @calderona, @makortel, @threus, @acaudron, @jhgoh, @geoff-smith, @jdolen, @HuguesBrun, @drkovalskyi, @ferencek, @OlivierBondu, @trocino, @rociovilar, @Sam-Harper, @barvic, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @ptcox, @nhanvtran, @gkasieczka, @rovere, @wmtford, @mschrode, @ebrondol, @mtosi, @dgulhan, @batinkov, @battibass, @varuns23, @gbenelli, @wddgit, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @matt-komm, @mariadalfonso, @pvmulder, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

+1
The FWCore/ based changes look fine.

@Dr15Jones
Copy link
Contributor

please test

@fabiocos
Copy link
Contributor

@davidlange6 @smuzaffar not sure who is Mr. cmsdoxy who should sign for docs, anyway the change looks transparent according to the syntax update, so I will just merge as soon as @civanch gives his green light

@davidlange6
Copy link
Contributor Author

davidlange6 commented May 23, 2018 via email

@civanch
Copy link
Contributor

civanch commented May 23, 2018

+1

@fabiocos
Copy link
Contributor

@davidlange6 you are correct, 8 days ago, I take it for good

@fabiocos
Copy link
Contributor

@civanch thanks

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28122/console Started: 2018/05/23 11:12

@cmsdoxy
Copy link
Contributor

cmsdoxy commented May 23, 2018

+1

@cmsbuild
Copy link
Contributor

-1

Tested at: c65dc6a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23208/28122/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testPythonParameterSet had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23208/28122/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901712
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901492
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

+1

residual differences in comparisons look unrelated to this PR but are the same observed in the overlapping #23065

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit bfa21dc into cms-sw:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment