New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply most of python futurist stage1 tools for python3 compatibility #23208
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23208/4667 |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Alignment/CommonAlignment @lveldere, @cmsdoxy, @kpedro88, @fabozzi, @nsmith-, @rekovic, @thomreis, @vanbesien, @arizzi, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @ssekmen, @mdhildreth, @jfernan2, @cerminar, @slava77, @ggovi, @fabiocos, @Martin-Grunewald, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @gpetruc, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
please test |
@davidlange6 @smuzaffar not sure who is Mr. cmsdoxy who should sign for docs, anyway the change looks transparent according to the syntax update, so I will just merge as soon as @civanch gives his green light |
note that @civanch signed already once...
… On May 23, 2018, at 10:51 AM, Fabio Cossutti ***@***.***> wrote:
@davidlange6 @smuzaffar not sure who is Mr. cmsdoxy who should sign for docs, anyway the change looks transparent according to the syntax update, so I will just merge as soon as @civanch gives his green light
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
+1 |
@davidlange6 you are correct, 8 days ago, I take it for good |
@civanch thanks |
please test |
The tests are being triggered in jenkins. |
+1 |
-1 Tested at: c65dc6a You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testPythonParameterSet had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 residual differences in comparisons look unrelated to this PR but are the same observed in the overlapping #23065 |
merge |
-f lib2to3.fixes.fix_apply
-f lib2to3.fixes.fix_except
-f lib2to3.fixes.fix_exitfunc
-f lib2to3.fixes.fix_funcattrs
-f lib2to3.fixes.fix_has_key
-f lib2to3.fixes.fix_idioms
-f lib2to3.fixes.fix_intern
-f lib2to3.fixes.fix_isinstance
-f lib2to3.fixes.fix_methodattrs
-f lib2to3.fixes.fix_ne
-f lib2to3.fixes.fix_numliterals
-f lib2to3.fixes.fix_paren
-f lib2to3.fixes.fix_reduce
-f lib2to3.fixes.fix_renames
-f lib2to3.fixes.fix_repr
-f lib2to3.fixes.fix_standarderror
-f lib2to3.fixes.fix_sys_exc
-f lib2to3.fixes.fix_throw
-f lib2to3.fixes.fix_tuple_params
-f lib2to3.fixes.fix_types
-f lib2to3.fixes.fix_xreadlines
-f libfuturize.fixes.fix_absolute_import
-f libfuturize.fixes.fix_next_call
-f libfuturize.fixes.fix_raise
["most" in terms of tools, but the remaining ones affect more code]
Other than the changes to argparse.py in RecoLuminosity changes are minor - the argparse file looks to be obsolete in any case. I'll look at removing it in favor of the standard one...